Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Fix padding for compact labeled icon button icon #601

Merged
merged 1 commit into from
Apr 5, 2019
Merged

[Button] Fix padding for compact labeled icon button icon #601

merged 1 commit into from
Apr 5, 2019

Conversation

lubber-de
Copy link
Member

Description

The icon padding had to be adjusted for compact labeled icon button, because the positioning of the icon was optimized to support loading icons in #361

Testcase

http://jsfiddle.net/0vp6kz2g/

Remove CSS to see the issue

Screenshot

Before After
image image

Closes

#598

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Mar 30, 2019
@lubber-de lubber-de added this to the 2.7.4 milestone Mar 30, 2019
@lubber-de lubber-de mentioned this pull request Mar 30, 2019
Closed
y0hami
y0hami approved these changes Mar 30, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de modified the milestones: 2.7.4, 2.7.5 Apr 2, 2019
ColinFrick
ColinFrick approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 488a4dc into fomantic:develop Apr 5, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Apr 5, 2019
@lubber-de lubber-de deleted the fix/598/misaligned_compact_labeled_icon_button branch April 6, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho prudho approved these changes

@y0hami y0hami y0hami approved these changes

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.5
Development

Successfully merging this pull request may close these issues.
4 participants
@lubber-de @ColinFrick @prudho @y0hami