[Label] Remove hardcoded color exception "not()" for menu item labels #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
lang/css
|
LGTM |
ColinFrick
approved these changes
Dec 31, 2018
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Menu Item Labels have a different default color (darker grey) than normal labels. To not interfere with the new dynamic colors, which do not use
!importantanymore, i originally (in #230) had to add:not({color})statements for each color to the menu item label.Now, having implemented the dynamic color system #261, this, still hardcoded, part of
:not()had to be removed from menu item labels to fully support individual color maps. Thus an increase of specificity for the labels was needed.Testcase
http://jsfiddle.net/7hp8m5og/