[Build] Travis npm fix #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hammy2899 I am unsure, if this would reintroduce #268 , so you may just create and push a fresh working package-lock.json (also npm suggests to keep the lock file in the repo) instead and decline this PR. |
|
@lubber-de Yeah I will just update the lock file because we shouldn't just remove it. As you mentioned it will break the event-stream patch and its a good thing to have for npm. |
|
As discussed and since @prudho seemed to fix it, lets forget about my attempt here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current Travis CI BUild process fails, because npm gets new sha512 hashes which do not match with the sha1 ones stored in package-lock.json.
Simply removing this file from the repo fixes it.