Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] Show "no results" when filterRemoteData is false and response is empty #300

Merged
merged 4 commits into from
Dec 17, 2018
Merged

[Dropdown] Show "no results" when filterRemoteData is false and response is empty #300

merged 4 commits into from
Dec 17, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 12, 2018 •
edited
Loading

Description

When a remoteApi returns no results according to the search query, the dropdown was still showing the previous filtered list when filterRemoteData was false (which is default)

Also fixed the behavior in combination that "no results" prevented possible allowed useradditions. So if allowAdditions is true, then "No results" will not be shown (this is how it already behaves when remote Api data was not used)

Hint: If you try to test the allowAdditions:true feature in the following fiddles and it does not work, then jsdelivr still caches an old commit. If in doubt, tell me, i'll put the whole JS in the fiddle then)

Testcase

  • Follow the 2 steps in the fiddles

Unfixed

https://jsfiddle.net/c092thvs/

Fixed

https://jsfiddle.net/c092thvs/1/

Closes

Semantic-Org/Semantic-UI#6603

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews labels Dec 12, 2018
@lubber-de lubber-de added the tag/sui-issue Taken from an existing Issue/PR of SUI label Dec 12, 2018
prudho
prudho previously approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami previously approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami dismissed stale reviews from prudho and themself via cef03a4 December 13, 2018 09:37
y0hami
y0hami approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added this to the 2.7.x milestone Dec 15, 2018
ColinFrick
ColinFrick approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 68b1d7a into fomantic:develop Dec 17, 2018
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Dec 17, 2018
@lubber-de lubber-de deleted the fix/6603/empty_menu_remotedata branch December 17, 2018 20:22
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.0 Dec 18, 2018
This was referenced Dec 21, 2018
Merged
Merged
@lubber-de lubber-de mentioned this pull request Apr 25, 2019
Open
@lubber-de lubber-de mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho prudho left review comments

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lubber-de @ColinFrick @prudho @y0hami