Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global]: Remove deprecated jquery functions #282

Merged
merged 2 commits into from
Dec 7, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 3, 2018

Description

jquery deprecated lots of methods. 3 of them are used widely in FUI. This PR prepares to work with a future jquery Version where those functions were removed.
You can also see this PR as a little step towards independency of jquery 🙂

  • $.isArray is replaced by native Array.isArray
  • $.isFunction and $.isWindow statements are adopted from jquery (the same wrapper as before, but put in FUI if not found in jquery)

…d $.isWindow if not available and replace $.isArray by native Array.isArray)
@lubber-de lubber-de added lang/javascript Anything involving JavaScript 📝 needs test case labels Dec 3, 2018
@lubber-de lubber-de added state/awaiting-reviews Pull requests which are waiting for reviews type/feat Any feature requests or improvements and removed 📝 needs test case labels Dec 3, 2018
@y0hami y0hami added 🔧 refactor and removed type/feat Any feature requests or improvements labels Dec 3, 2018
…nent where they are used to support single component file usage
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit ee4b02c into fomantic:develop Dec 7, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 7, 2018
@lubber-de lubber-de deleted the deprecated_jquery branch December 7, 2018 12:17
@lubber-de lubber-de added this to the 2.7.0 milestone Dec 7, 2018
This was referenced Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants