Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input, Textarea] Support for corner label and icon in textarea #277

Merged
merged 6 commits into from
Dec 3, 2018
Merged

[Input, Textarea] Support for corner label and icon in textarea #277

merged 6 commits into from
Dec 3, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Nov 30, 2018 •
edited
Loading

Description

This PR supports corner label and icon for textarea when using the input class

Testcase

All possible features can be seen here

Screenshot

image

Closes

#276

@lubber-de lubber-de added type/feat Any feature requests or improvements state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Nov 30, 2018
@lubber-de lubber-de added this to the 2.7.0 milestone Nov 30, 2018
@lubber-de lubber-de added the lang/css Anything involving CSS label Nov 30, 2018
ColinFrick
ColinFrick approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 41c4d3d into fomantic:develop Dec 3, 2018
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Dec 3, 2018
@lubber-de lubber-de deleted the feat/276/corner_label_icon_textarea branch December 3, 2018 11:14
@lubber-de lubber-de mentioned this pull request Dec 3, 2018
Merged
@lubber-de lubber-de removed the state/awaiting-docs Pull requests which need doc changes/additions label Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami