[Table] fix table wide vertical+text alignment #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
y0hami
removed
the
state/awaiting-reviews
This was referenced Dec 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default thead and tbody don't inherit a probably given alignment from its parent table element itself. To make this work clean in FUI, this PR moves the default middle vertical alignment (by the browser, not by the framework) to the top element table instead and makes thead and tbody inherit from that.
This way a
bottom|middle|top alignmentgiven to a table directly works as intended in every browser )Testcase
https://jsfiddle.net/cws74Lpk/6/
Closes
Semantic-Org/Semantic-UI#6516