[Dropdown] Suppress events on enter key with multiple allowAdditions #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore/2.6.4 release
…prevent form submission
lubber-de
added
type/bug
lubber-de
removed
the
state/awaiting-reviews
This was referenced Dec 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The event bubbling was not suppressed when the enter key was used on new entries in a dropdown box. In the given SUI Issue this resulted in forwarding the enter-key event to the submit button of a form when that was the next form component
Screenshot
Look at the captured console at the bottom of each screenshot. I added a form-submit handler to write 'SUBMIT' to the console whenever a form submission was triggered. Before the fix, this was happening on every pressing of the enter-key. After that this only happens when you click on the submit button
Before
After
Closes
Semantic-Org/Semantic-UI#6672