Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu.less extra .menu.menu #672

Closed
beamsky opened this issue Apr 15, 2019 · 2 comments
Closed

menu.less extra .menu.menu #672

beamsky opened this issue Apr 15, 2019 · 2 comments
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Milestone
2.7.5

Comments

@beamsky
Copy link

beamsky commented Apr 15, 2019

First time posting so please point me in the right direction if my format is wrong for reporting a potential issue.

In Semantic-ui for menu.less line 892 it is:
/* Inverted */ .ui.secondary.inverted.menu { background-color: transparent; }

In fomantic-ui for menu.less on line 914 it is:
/* Inverted */ .ui.secondary.inverted.menu.menu { background-color: transparent; }

The extra .menu from what I can tell should not be there. I found this because my color override from Semantic stopped working when switching over to Fomantic.

Let me know if I can provide any more details.
@beamsky beamsky changed the title menu.less line 930 extra .menu.menu menu.less extra .menu.menu Apr 15, 2019
@lubber-de lubber-de mentioned this issue Apr 16, 2019
Merged
@lubber-de
Copy link
Member

@beamsky
Basically you could override it as you wish by also increasing specificity like
.ui.ui.ui.inverted.secondary.menu
That additional specificity you mentioned was necessary (at that time), but not anymore, you are right.
Fixed by and more details in #673

@lubber-de lubber-de added 📝 needs test case lang/css Anything involving CSS labels Apr 16, 2019
@lubber-de lubber-de added this to the 2.7.5 milestone Apr 16, 2019
@lubber-de lubber-de added type/feat Any feature requests or improvements and removed 📝 needs test case labels Apr 16, 2019
@beamsky
Copy link
Author

beamsky commented Apr 16, 2019

Thank you @lubber-de .. The work you all are putting in is really appreciated.

@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Apr 18, 2019
exoego pushed a commit to exoego/Fomantic-UI that referenced this issue Apr 30, 2019
@lubber-de
fix(menu): additional specificity for secondary inverted menu no long…
d5580ab 
…er needed

The additional specificity for `secondary inverted menu` was necessary (when 2.7.0 was released) to override a background color setting when `secondary` was still supported as a background color for menus. We removed this in fomantic#366 , so the additional specificity is not needed anymore

Closes fomantic#672
@y0hami y0hami closed this as completed in 8917519 May 16, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.5
Development

No branches or pull requests
2 participants
@lubber-de @beamsky