Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] Recreating opened dropdown doesn't restore intent event handlers #654

Closed
unarist opened this issue Apr 10, 2019 · 1 comment
Closed

[Dropdown] Recreating opened dropdown doesn't restore intent event handlers #654

unarist opened this issue Apr 10, 2019 · 1 comment
Assignees
@lubber-de
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.5

Comments

@unarist
Copy link

unarist commented Apr 10, 2019

Bug Report

Steps to reproduce

  1. Open the dropdown by clicking
  2. Recreate the dropdown by .dropdown() (The dropdown is still opened)
  3. Click anywhere except inside of the dropdown

Expected result

It closes the dropdown.

Actual result

It does not.

Recreating seems to remove existing intent event handlers, but handlers won't be restored after recreation.

Testcase

https://jsfiddle.net/5mvr93dL/

Version

2.7.4
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript labels Apr 10, 2019
@lubber-de lubber-de self-assigned this Apr 10, 2019
@lubber-de lubber-de mentioned this issue Apr 10, 2019
Merged
@lubber-de
Copy link
Member

Fixed by #657
The handlers were restored just fine, but the open menu let the "new" dropdown think its menu is hidden, although the "old" dom was still visible
See your adjusted fiddle here https://jsfiddle.net/c62bagsn/

@lubber-de lubber-de added this to the 2.7.5 milestone Apr 10, 2019
y0hami pushed a commit that referenced this issue Apr 11, 2019
@lubber-de
fix(dropdown): hide open menus on destroy for correct state reset
c374bcf 
Closes #653, #654
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Apr 11, 2019
exoego pushed a commit to exoego/Fomantic-UI that referenced this issue Apr 30, 2019
@lubber-de
fix(dropdown): hide open menus on destroy for correct state reset
aca21ae 
Closes fomantic#653, fomantic#654
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lubber-de lubber-de

Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.5
Development

No branches or pull requests
2 participants
@unarist @lubber-de