Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List] Icons in lists don't line up #597

Closed
Merlin04 opened this issue Mar 29, 2019 · 1 comment
Closed

[List] Icons in lists don't line up #597

Merlin04 opened this issue Mar 29, 2019 · 1 comment
Labels
lang/css Anything involving CSS tag/good-first-issue Good issues for new starters to try type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.5

Comments

@Merlin04
Copy link

Bug Report

Steps to reproduce

  1. Make a list with different icons like in the List examples

Expected result

The left side of the text lines up

Actual result

The left side of the icon lines up

Testcase

https://jsfiddle.net/4gkvha2b/

Version

2.7.2
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS tag/good-first-issue Good issues for new starters to try labels Mar 29, 2019
@globophobe
Copy link
Contributor

How about a reasonable default min-width?

.ui.list > .item > i.icon {
  min-width: 1.55em;
}

https://jsfiddle.net/tkuyoj4r/

globophobe added a commit to globophobe/Fomantic-UI that referenced this issue Apr 30, 2019
@globophobe
[List] Align text in lists with icons
11768d5 
Define min-width for icon in lists, so text is aligned.

Closes fomantic#597
@globophobe globophobe mentioned this issue Apr 30, 2019
Merged
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label May 1, 2019
@lubber-de lubber-de added this to the 2.7.5 milestone May 1, 2019
@y0hami y0hami closed this as completed in 566b363 May 16, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/good-first-issue Good issues for new starters to try type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.5
Development

No branches or pull requests
3 participants
@globophobe @Merlin04 @lubber-de