Skip to content

Commit

Permalink
fix(dimmer): disable blur on popups
Browse files Browse the repository at this point in the history
If content within a dimmer, most likely a modal, uses a popup and the dimmer is blurred, then the popup itself also gets blurred, because the popup is rendered as a direct sibling to body.

There indeed exists a setting `inline` which will also prevent this behavior, but `inline:true` will also keep all popup markup in the DOM once created, which might unnecessarily bloat the domtree and might not be the desired side effect.

As a popup is never supposed to stay open, but will always vanish before a modal is shown it's save to not blur any popup as a direct sibling of body (no popup outside of the modal will be triggered). (And in case the popup option `closable:false` is used, one definately wants to control all the popups on his own anyway)
  • Loading branch information
lubber-de authored and Sean committed Apr 8, 2019
1 parent 57718ce commit f10dd0b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/definitions/modules/dimmer.less
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ body.dimmable > .dimmer {
filter: @blurredStartFilter;
transition: @blurredTransition;
}
.blurring.dimmed.dimmable > :not(.dimmer) {
.blurring.dimmed.dimmable > :not(.dimmer):not(.popup) {
filter: @blurredEndFilter;
}

Expand Down

0 comments on commit f10dd0b

Please sign in to comment.