fix(fzf-lua): ordering of messages in fzf #1038
Open
+17
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Message entries shown in fzf weren't sorted correctly.
Even though the
messages
are sorted initially, the order is broken when they are moved toret
:I made
find
return a sorted list ofNoiceEntry
, and moved the part where the id to message map is created intoopen
.Related Issue(s)
I mentioned this problem in #1037, but this PR doesn't solve the main issue (yet)