Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fzf-lua): ordering of messages in fzf #1038

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sufftea
Copy link

@sufftea sufftea commented Jan 15, 2025

Description

Message entries shown in fzf weren't sorted correctly.

Even though the messages are sorted initially, the order is broken when they are moved to ret:

  ---@type table<number, NoiceEntry>
  local ret = {}

  for _, message in ipairs(messages) do
    ret[message.id] = M.entry(message)
  end

I made find return a sorted list of NoiceEntry, and moved the part where the id to message map is created into open.

Related Issue(s)

I mentioned this problem in #1037, but this PR doesn't solve the main issue (yet)

@sufftea sufftea changed the title Fix: ordering of messages in fzf fix: ordering of messages in fzf Jan 15, 2025
@sufftea sufftea changed the title fix: ordering of messages in fzf fix(fzf-lua): ordering of messages in fzf Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant