-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not compatible with neovide #17
Comments
In the route, you specify it needs to go to the Just remove the routes in your config. |
Nevermind, that's for the search cmdline |
Just tried your config and it works for me. |
So I removed all the configs and just stuck to the default. I think I know what's happening. It seems to be incompatible with |
Please see this. |
For me the popup etc does work in the latest Neovide version, but there's another issue with I'll keep this open for now and will add it to the tracking issue |
Is this with our without |
I run Neovide with |
So I just tested again with the latest version of Neovide, Neovim & Noice, and everything seems to be working now :) I pushed a change, so that Noice still shows a warning of running inside Neovide, but it will start. Would be great if others can test as well to see that everything is working inside Neovide now. @clason with |
@alerque try without multigrid. It seems to work fine for me |
That would be my expectation as well; |
@folke What's the point? When I want to forego smooth scrolling to get noice features I just run NeoVIM in a terminal. |
@alerque the point was to test and see if that works for you as well, so we can narrow down the issue to |
In any case, can I suggest turning the hard error into a warning, even with |
Sorry @folke I thought that had been determined already. Yes if I disable |
@clason did that already :) |
@james2doyle that doens't seem right. Thats the call to It seems like your installation (runtime directory) is messed up. |
Ah ok. I will look into that. I used to build from source before 0.8 was out so I am sure it is a holdover from the mess I made |
Very likely then. Clean out your runtime directory and install again. |
Got it. I had a custom set ENV VAR for it and once it was removed it worked perfectly |
I've opened neovim/neovim#22344 for this. |
For me everything is ok so far... I don't know guys how you can use |
Ok, it crahes for me if I do |
Is it possible to fix with noice settings? I mean deletion bug |
@xbladesub first of all, you should be running Neovim Nightly, to minimize any segfaults. That notification window you see is nvim-notify. Just disable it if you don't want that |
I have tree-sitter issues with rust buffers on nightly neovim. I just disabled everything except cmdline and it's ok, can work. But still crashes sometimes while starting to search with |
any update on this guys? |
Gonna add this in here, maybe it's related, It has also been mentioned on this thread, same crash as with |
When I excute |
neovim/neovim#22344 (comment) References: |
It has been reported here for example neovide/neovide#1737 (comment) that disabling the messages stops the crashes. This is constantly causing headaches for Neovide users, since it's not clear for them what's causing the problem. @folke, would it be possible to disable that automatically with a warning or something, if Neovide is running? You can check with On the Neovide side, there's not much we can do, since the event we receive from Neovim is completely malformed. |
@fredizzimo that's already the case. This message is shown for users running noice inside Neovide: fyi: I'm not sure what is diffrerent with other GUIs but for the others I tested, Noice does not seem to be causing issues. It's been a while since I tested in other GUIs though, so maybe some upstream Neovim issues might have been introduced in the meantime. |
@ryo33 it's unfortunately not that simple. The big issue is that noice implements |
I'm pretty confident I was able to fix Noice with Neovide. It should even work properly with The fix turned out to be easy and straightforward. Basically, Noice stops propagating events handled by Noice to other GUis that may be attached. (messages, cmdline and popupmenu, unless they're disabled in the Noice config) Would be great if others can confirm this no longer crashes Neovide. |
Can confirm Neovide no longer crashes 🎉 thanks for that fix @folke! |
Fixes it for me too! Thank you! |
Works fine even for |
@Ciel-MC that doesn't have anything to do with Neovide I think. |
I disablo it with :NoiceDisable I'm not sure, I suspect it is due to cmp trying to trigger completion? I think it's to do with Neovide because it doesn't happen when I use the terminal |
Describe the bug
I've installed the plugin with packer. Used one of the config recipes from the wiki but I can't get it to work.
To Reproduce
Install with Packer
Copy the config recipe from the wiki:
I also tried without lazy loading and still didn't work. Also tried running
Noice enable
, didn't work.Expected behavior
I'd expect the command line to appear in a popup on the center of the screen.
Screenshots
This is how my command line looks.
Noice log
Noice log is empty.
Here are the stats:
The text was updated successfully, but these errors were encountered: