Updated tests (critical path and smoke) with cy.visit() #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sherzod-Kenjaev
changed the title
sviatlana-stsiapanava
approved these changes
Oct 2, 2024
Sherzod-Kenjaev
changed the title
eremv
reviewed
Oct 2, 2024
| @@ -120,23 +121,22 @@ describe('MARC', () => { | |||
| }); | |||
|
|
|||
| cy.loginAsAdmin(); | |||
There was a problem hiding this comment.
In this case it's better to use something like this
cy.loginAsAdmin({
path: TopMenu.inventoryPath,
waiter: InventoryInstances.waitContentLoading,
}).then(() => {
InventoryInstances.searchByTitle(testData.createdAuthorityID[0]);
InventoryInstances.selectInstance();
InventoryInstance.editMarcBibliographicRecord();
.....
Because you can't avoid very first time visit call, so you can navigate to nessesary page within admin log in call.
| @@ -177,28 +178,27 @@ describe('MARC', () => { | |||
| }); | |||
|
|
|||
| cy.loginAsAdmin(); | |||
ostapwd
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/FAT-16829