- remove unused

pom.xml

@@ -404,10 +404,10 @@
             <sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
             <sourceDirectory>${project.build.testSourceDirectory}</sourceDirectory>
           </sourceDirectories>
-          <failsOnError>false</failsOnError>
+          <failsOnError>true</failsOnError>
           <violationSeverity>warning</violationSeverity>
-          <failOnViolation>false</failOnViolation>
-          <logViolationsToConsole>false</logViolationsToConsole>
+          <failOnViolation>true</failOnViolation>
+          <logViolationsToConsole>true</logViolationsToConsole>
           <configLocation>checkstyle/checkstyle.xml</configLocation>
           <cacheFile>${basedir}/target/cachefile</cacheFile>
         </configuration>

src/main/java/org/folio/search/cql/SuDocCallNumber.java

@@ -104,7 +104,7 @@ private void appendWithSymbolIfNeeded(StringBuilder key, String cnPart) {
     }
     var parts = cnPart.split("[./ -]");
     for (String part : parts) {
-      if (key.length() > 0) {
+      if (!key.isEmpty()) {
         key.append(' ');
       }
       part = part.trim();

src/main/java/org/folio/search/integration/ResourceFetchService.java → src/main/java/org/folio/search/integration/InstanceFetchService.java

@@ -13,7 +13,6 @@
 import lombok.RequiredArgsConstructor;
 import lombok.extern.log4j.Log4j2;
 import org.apache.commons.collections.CollectionUtils;
-import org.folio.search.client.InventoryViewClient;
 import org.folio.search.domain.dto.ResourceEvent;
 import org.folio.search.domain.dto.ResourceEventType;
 import org.folio.search.service.reindex.jdbc.UploadInstanceRepository;
@@ -23,11 +22,8 @@
 @Log4j2
 @Service
 @RequiredArgsConstructor
-public class ResourceFetchService {
+public class InstanceFetchService {
 
-  private static final int BATCH_SIZE = 50;
-
-  private final InventoryViewClient inventoryClient;
   private final FolioExecutionContext context;
   private final UploadInstanceRepository instanceRepository;
 

src/main/java/org/folio/search/integration/KafkaMessageListener.java

@@ -24,7 +24,6 @@
 import org.apache.kafka.clients.consumer.ConsumerRecord;
 import org.apache.logging.log4j.message.FormattedMessage;
 import org.folio.search.domain.dto.ResourceEvent;
-import org.folio.search.model.event.ConsortiumInstanceEvent;
 import org.folio.search.model.types.ResourceType;
 import org.folio.search.service.ResourceService;
 import org.folio.search.service.config.ConfigSynchronizationService;
@@ -203,13 +202,4 @@ private static void logFailedEvent(ResourceEvent event, Exception e) {
     ), e);
   }
 
-  private static void logFailedConsortiumEvent(ConsortiumInstanceEvent event, Exception e) {
-    if (event == null) {
-      log.warn("Failed to index resource event [event: null]", e);
-      return;
-    }
-
-    log.warn(new FormattedMessage("Failed to index consortium instance [tenantId: {}, id: {}]",
-      event.getTenant(), event.getInstanceId()), e);
-  }
 }