forked from 7h0ma5/QLog
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSN S.A.T. Device UDP #610
Open
aa5sh
wants to merge
4
commits into
foldynl:master
Choose a base branch
from
aa5sh:SATUDP
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to make it work to receive log entries from CSN Sat device.
Is there a better way to detect this than to search the datagram like this |
Ok thank makes sense. Maybe I can move a check inside of the case 12
statement and only check if the adif_text is blank or otherwise
incomplete. I will think on it some more. But I believe the text should
also be pretty consistent in it's location so I could also change the
contains to the specific location as well. I'll tighten it up and resubmit.
Thanks for the feedback. But also I think if it was detected incorrectly
it should still process the entry I am just chopping the datagram manually
instead of feeding the string with the >>.
…On Wed, Feb 26, 2025 at 7:50 AM Ladislav ***@***.***> wrote:
Is there a better way to detect this than to search the datagram like this bool
IsCSNSat = datagram.data().contains("CSN Sat");?
I know it's unlikely, but this is dangerous in my opinion in the case that
if someone gives this string to WSTJX's notes, it will detect it
incorrectly. It would be better to determine where the string is expected
in the received message.
—
Reply to this email directly, view it on GitHub
<#610 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUEEMXWL5MVRQ7GCVMKB5UL2RXBDZAVCNFSM6AAAAABX4ISLLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGA3DIMBUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: foldynl]*foldynl* left a comment (foldynl/QLog#610)
<#610 (comment)>
Is there a better way to detect this than to search the datagram like this bool
IsCSNSat = datagram.data().contains("CSN Sat");?
I know it's unlikely, but this is dangerous in my opinion in the case that
if someone gives this string to WSTJX's notes, it will detect it
incorrectly. It would be better to determine where the string is expected
in the received message.
—
Reply to this email directly, view it on GitHub
<#610 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUEEMXWL5MVRQ7GCVMKB5UL2RXBDZAVCNFSM6AAAAABX4ISLLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGA3DIMBUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Moved the IF statement to only be in the mtype 12 and to further define the programid to limit any possible false positives.
removed unused variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently starting to try and operate Satellites. I am using one of these devices. It has an option to perform logging as well as can either export log entries or send a UDP blast. It has an option it says is for MacLoggerDX over port 2237. Which made me think QLog should be able to grab it. But looks like it usings 99% the format of WSJT-X. I made a condition to try and detect if the UDP from the CSN device and try to account for it not reading the adif_text part of the blast. I did also open a support request with the vendor to see if they may could make an adjustment so it would more align with the WSJT-X. From looking at it, it appears it may be missing a " before the <ADIF_VER> tag.


WSJT-X
CSN SAT
If they are able to make it work on this end I will kill this Pull request, if not I would like for it to be considered.
I built a test version so you can ignore the entitlements and action file.
Thanks