Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ADIF #176

Closed
magnum88 opened this issue Feb 22, 2023 · 5 comments
Closed

Import ADIF #176

magnum88 opened this issue Feb 22, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@magnum88
Copy link

Hi
when import adif
on 323 QSO only 1 imported
the first line file adi
the other 322 no imported in QLOG
no error present on the software qlog and no error on my file beacause it's the same file for QRZ.COM
Same problem on package installed or source compiled
QLog 0.19.0
Based on Qt 5.15.3
Hamlib 4.5~git
Ubuntu 22.04.2 LTS x86_64

@foldynl
Copy link
Owner

foldynl commented Feb 22, 2023

Please, could you send me the file or just the first 10 QSOs from the file?

@magnum88
Copy link
Author

magnum88 commented Feb 22, 2023 via email

@foldynl
Copy link
Owner

foldynl commented Feb 22, 2023

Many thanks for provided ADI records. They help me to identify many issues in QLog related to QSL handling.

Unfortunately, there are following issues in QLog:

  1. QLog has incorrectly defined EQSL_QSL_SENT values because 'Q' value is missing in the list of supported values for EQSL_QSL_SENT. That is not critical issue because it can be change very quickly.
  2. what is a more serious issue is that QLog interprets these values incorrectly. Unfortunately, the fix will be quite complicated.

I'm sorry, but I don't have a quick fix for this now.

@magnum88
Copy link
Author

magnum88 commented Feb 22, 2023 via email

@foldynl
Copy link
Owner

foldynl commented Feb 22, 2023

Xavier,

the situation is not as simple as it may seem.

Yes, it is possible to give a workaround to change Q to something else. But during my analysis, I found out that I misunderstood the values of EQSL_QSL_SENT.

The behavior of the QLog is as follows now:

  • QLog interprets N as "QSO not sent but should be uploaded", Y as "it was successfully uploaded". Other values are accepted, but have no special meaning.
  • QLog sends QSO to "online" service in case when qsl_sent is different from Y - what is totally wrong.

Based on ADIF spec:
N - do not send an outgoing QSL card; do not upload the QSO to the online service
Y - an outgoing QSL card has been sent; the QSO has been uploaded to, and accepted by, the online service
Q - an outgoing QSL card has been selected to be sent; a QSO has been selected to be uploaded to the online service
R - the contacted station has requested a QSL card; the contacted station has requested the QSO be uploaded to the online service

Qlog uses the default value N now. And here is the problem. If N means "not sent and will not send" , then QLog's issue is in the default value for QSL Sent value. I guess that the correct default value should be Q. And only Q and R QSOs should be uploaded to online service. If QSO is successfully uploaded to online log then the value should change to Y. N can be set by operator when QSO should never be uploaded to online service.

@foldynl foldynl added the bug Something isn't working label Feb 22, 2023
foldynl added a commit that referenced this issue Mar 1, 2023
foldynl added a commit that referenced this issue Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants