Database connection control options #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduced a connection control struct as an aggregate of options. This opens the way for various options and modes to establish a database connection. * An 'on open' callback can now be specified in a declarative way to the `make_storage()` call. This finally solves the issue that in-memory databases didn't call the 'on open' callback. * Reordered members of the connection holder. This will be important for upcoming multi-threading improvements, avoiding false L1 cache sharing.
fnc12
approved these changes
Feb 18, 2025
Older compilers such as Visual C++ 16.11 [msvc 1929] choke on deeply nested alias template expressions and can be made happy by unraveling these expressions.
… upstream/connection_control
fnc12
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_storage("", connection_control{.open_forever = true});. Also see PR #1392 : Add support for SQLite VFS and open mode flags #1393.make_storage()call. This finally solves the issue that in-memory databases didn't call the 'on open' callback. E.g.make_storage("", on_open([](sqlite3* db) {}));.