Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce warnings, support #809 #811

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Reduce warnings, support #809 #811

merged 1 commit into from
Jul 17, 2018

Conversation

henryiii
Copy link
Contributor

Slightly uglier than #803 , but should support MSVC's built-in CMake.

@henryiii
Copy link
Contributor Author

@Aletschhorn, please see if this works.

whannes
whannes approved these changes Jul 17, 2018
View reviewed changes
Copy link

@whannes whannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thanks

@vitaut vitaut merged commit efd8ee8 into fmtlib:master Jul 17, 2018
@vitaut
Copy link
Contributor

vitaut commented Jul 17, 2018

Merged, thanks!

@henryiii henryiii deleted the cmakesup branch July 24, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whannes whannes whannes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryiii @vitaut @whannes