Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilation fix & warnings #653

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

alabuzhev
Copy link
Contributor

No description provided.

struct accessor: iterator {
accessor(iterator it) : iterator(it) {}
using iterator::container;
typedef std::back_insert_iterator<Container> bi_iterator;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason VS cannot compile this:

core.h(807): error C2327: 'std::back_insert_iterator<fmt::internal::basic_buffer>::container': is not a type name, static, or enumerator

renaming iterator to bi_iterator helped.

@@ -865,11 +865,8 @@ typedef buffer_context<wchar_t>::type wcontext;
namespace internal {
template <typename Context, typename T>
class get_type {
private:
static const T& val();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc warning: all member functions in class 'class' are private [-Wctor-dtor-privacy]
With declval there is no need for this.

@alabuzhev alabuzhev force-pushed the compilation_fix_and_warnings branch 2 times, most recently from 7e15547 to eaf19a4 Compare February 15, 2018 17:15
@alabuzhev alabuzhev force-pushed the compilation_fix_and_warnings branch from eaf19a4 to 977cee4 Compare February 15, 2018 17:28
@vitaut vitaut merged commit 24d66c5 into fmtlib:master Feb 16, 2018
@vitaut
Copy link
Contributor

vitaut commented Feb 16, 2018

Merged, thanks!

@alabuzhev alabuzhev deleted the compilation_fix_and_warnings branch February 16, 2018 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants