Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing type of data_ to size_t to avoid compilation errors #4200

Merged
merged 6 commits into from
Oct 19, 2024
Merged

Changing type of data_ to size_t to avoid compilation errors #4200

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7cc38b5
Remove type cast as mxe(mingw32) compiler complains about useless-cast
vinayyadav3016 Sep 5, 2023
5b12be2
Moved 'args' to previous line as requested
vinayyadav3016 Sep 5, 2023
55891cd
Merge remote-tracking branch 'source/master'
vinayyadav3016 Oct 14, 2024
7937ff9
mingw32 cause compilation failure when -Wconversion is enabled while
vinayyadav3016 Oct 15, 2024
83778bd
reverting changes since it was causing gcc compilation failed with
vinayyadav3016 Oct 15, 2024
e92c2d9
Changing type data_ to size_t which is more of concrete type because
vinayyadav3016 Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/fmt/base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@ class basic_specs {
max_fill_size = 4
};

unsigned long data_ = 1 << fill_size_shift;
size_t data_ = 1 << fill_size_shift;

// Character (code unit) type is erased to prevent template bloat.
char fill_data_[max_fill_size] = {' '};
Expand Down
Loading