Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage with std::generator #4057

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix usage with std::generator #4057

merged 1 commit into from
Jul 9, 2024

Conversation

Arghnews
Copy link
Contributor

@Arghnews Arghnews commented Jul 7, 2024

Fixes #4053

Tested on (docker image) Ubuntu 24.04 with gcc 14

vitaut
vitaut requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR but could you add a test case that exercises this path to ranges-test?

@Arghnews
Copy link
Contributor Author

Arghnews commented Jul 8, 2024 •
edited
Loading

Thanks for the PR but could you add a test case that exercises this path to ranges-test?

Sure thing, will do.

I'll put the test behind an ifdef for __cpp_lib_generator
Note though, that currently only gcc14 supports the <generator> header, see https://en.cppreference.com/w/cpp/compiler_support#cpp23
So if you would like the fmtlib CI test matrix to actually test this code, it would need an Ubuntu 24.04 instance with gcc 14 added to the github workflows

@vitaut
Copy link
Contributor

vitaut commented Jul 8, 2024

I think we don't need to use generator, just some range with move-only iterators.

@Arghnews Arghnews force-pushed the fix_std_generator branch from a12f910 to a0572b0 Compare July 8, 2024 23:24
@Arghnews
Copy link
Contributor Author

Arghnews commented Jul 8, 2024

I think we don't need to use generator, just some range with move-only iterators.

Good point, have added a test

@vitaut vitaut merged commit e60ff50 into fmtlib:master Jul 9, 2024
43 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jul 9, 2024

Merged, thanks!

@BrewTestBot BrewTestBot mentioned this pull request Jul 20, 2024
Closed
mtremer pushed a commit to ipfire/ipfire-2.x that referenced this pull request Aug 15, 2024
@mtremer
fmt: Update to version 11.0.2
ee4c4c7 
- Update from version 11.0.1 to 11.0.2
- Update of rootfile
- Changelog
    11.0.2
	- Fixed compatibility with non-POSIX systems
	  (fmtlib/fmt#4054,
	  fmtlib/fmt#4060).
	- Fixed performance regressions when using `std::back_insert_iterator` with
	  `fmt::format_to` (fmtlib/fmt#4070).
	- Fixed handling of `std::generator` and move-only iterators
	  (fmtlib/fmt#4053,
	  fmtlib/fmt#4057). Thanks @Arghnews.
	- Made `formatter<std::string_view>::parse` work with types convertible to
	  `std::string_view` (fmtlib/fmt#4036,
	  fmtlib/fmt#4055). Thanks @Arghnews.
	- Made `volatile void*` formattable
	  (fmtlib/fmt#4049,
	  fmtlib/fmt#4056). Thanks @Arghnews.
	- Made `Glib::ustring` not be confused with `std::string`
	  (fmtlib/fmt#4052).
	- Made `fmt::context` iterator compatible with STL algorithms that rely on
	  iterator category (fmtlib/fmt#4079).

Signed-off-by: Adolf Belka <[email protected]>
Signed-off-by: Michael Tremer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trunk doesn't work with std::generator
2 participants
@Arghnews @vitaut