Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress a bogus warning in MSVC #4023

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Jun 17, 2024

<source_location> and <ranges> is C++20 heades (FMT_CPLUSPLUS > 201703L), not C++17 (FMT_CPLUSPLUS >= 201703L).

Warnings:

The contents of <ranges> are available only with C++20 or later.
The contents of <source_location> are available only with C++20 consteval support.

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

include/fmt/std.h Show resolved Hide resolved
Signed-off-by: Vladislav Shchapov <[email protected]>
@phprus phprus force-pushed the msvc-cplusplus-2 branch from b20b9a6 to 3d879c8 Compare June 19, 2024 15:07
@vitaut vitaut merged commit 514b695 into fmtlib:master Jun 19, 2024
43 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jun 19, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants