Add FMT_FORCE_FALLBACK_FILE to force the use of fallback_file #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The doc CI failure is unrelated, please ignore. |
vitaut
requested changes
Jun 11, 2024
| @@ -1600,6 +1600,7 @@ template <typename F> class fallback_file : public file_base<F> { | |||
| } | |||
| }; | |||
|
|
|||
| #ifndef FMT_FORCE_FALLBACK_FILE | |||
There was a problem hiding this comment.
Let's rename to FMT_USE_FALLBACK_FILE for consistency with other similar macros and make it take value 0 or 1, see e.g.
Lines 158 to 164 in a5c1b5d
|
Merged with minor tweaks in 2c0d9e9, thanks. |
This was referenced Jul 1, 2024
This was referenced Jul 1, 2024
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a define to opt out of attempting to use the library/platform specific files, as mentioned in #3992
Specifically this helps work around an issue with apple_file is detected for use on some platforms (ie game consoles) but has buffered functionality that the platform may not support, which can cause crashes.