Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FMT_INSTALL with FMT_MODULE #3998

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

yujincheng08
Copy link
Contributor

Error:

  install TARGETS target fmt is exported but not all of its interface file
  sets are installed

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Mostly looks good but I wonder if the include directory is the right place to install sources.

@fmtlib fmtlib deleted a comment Jun 8, 2024
@yujincheng08
Copy link
Contributor Author

@vitaut basically there's no "standard" place to place the install sources. So it's free to place anywhere, as long as cmake can help export the correct FILE_SET to dependants

@vitaut vitaut merged commit fcc0b49 into fmtlib:master Jun 8, 2024
41 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jun 8, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants