github: update lint.yml to post details on formatting issue #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change, user need to click into the details for more details on the formatting issue identified by the lint workflow. after this change, the workflow pastes the details with a comment, to provide more specific details on the formatting issue if any. Signed-off-by: Kefu Chai <[email protected]>
|
for an example of the change in action, see tchaikov#2 (comment) . where i updated the tree with clang-fmt 19, and send the formatted tree as a PR. and the workflow pasted the diff as expected. because, apparently, clang-fmt 17 and clang-fmt 19 have different tastes on the formatting. |
|
This looks great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, contributers need to click into the "details" link for more details on the formatting issue identified by the lint workflow.
after this change, the workflow pastes the details with a comment, to provide more specific details on the formatting issue if any.