Update checks for dynamic_cast usage when compiled with no rtti #3963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FMT_USE_TYPEID
macro was renamed toFMT_HAS_RTTI
and moved tofmt/base.h
so that it can be used in other parts of the library.That is now used to check wheter or not dynamic_cast should be used in the codebase, currently the only instances were in
write_ostream_unicode
.This allows the library to be compiled properly with rtti disabled.