Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL alert #3945

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fix CodeQL alert #3945

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8f522b
Fix CodeQL alert
marlenecota Apr 29, 2024
58c6ecc
static_cast<unsigned>(id)
marlenecota Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion include/fmt/base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1902,7 +1902,9 @@ template <typename Context> class basic_format_args {
if (id >= detail::max_packed_args) return arg;
marlenecota marked this conversation as resolved.
Show resolved Hide resolved
arg.type_ = type(id);
marlenecota marked this conversation as resolved.
Show resolved Hide resolved
if (arg.type_ == detail::type::none_type) return arg;
arg.value_ = values_[id];
if (id >= 0) {
arg.value_ = values_[id];
}
return arg;
}

Expand Down
Loading