Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FMT_IMPORT_STD feature macro #3928

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

matt77hias
Copy link
Contributor

How to use? Add #define FMT_IMPORT_STD underneath module; in fmt.cc.

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please address the inline comments and apply clang-format to your changes.

include/fmt/base.h Outdated Show resolved Hide resolved
include/fmt/base.h Outdated Show resolved Hide resolved
include/fmt/format.h Outdated Show resolved Hide resolved
@matt77hias matt77hias force-pushed the import-std branch 2 times, most recently from f84e720 to dce097a Compare April 9, 2024 18:48
include/fmt/format-inl.h Outdated Show resolved Hide resolved
include/fmt/format.h Outdated Show resolved Hide resolved
include/fmt/format-inl.h Outdated Show resolved Hide resolved
include/fmt/std.h Outdated Show resolved Hide resolved
@vitaut vitaut merged commit 116a9ce into fmtlib:master Apr 10, 2024
41 checks passed
@vitaut
Copy link
Contributor

vitaut commented Apr 10, 2024

Merged, thanks!

@matt77hias matt77hias deleted the import-std branch April 10, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants