-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: enable FMT_NORETURN
without exception support too
#3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Overall looks reasonable but please apply clang-format.
When building `format.cc` as such with GCC 13.2.1: $ g++ -c format.cc -DFMT_EXCEPTIONS=0 -Wmissing-noreturn -Werror I get: In file included from format.cc:8: fmt/format-inl.h: In function ‘void fmt::v10::detail::assert_fail(const char*, int, const char*)’: fmt/format-inl.h:30:15: error: function might be candidate for attribute ‘noreturn’ [-Werror=suggest-attribute=noreturn] 30 | FMT_FUNC void assert_fail(const char* file, int line, const char* message) { | ^~~~~~~~~~~ fmt/format-inl.h: In function ‘void fmt::v10::report_error(const char*)’: fmt/format-inl.h:129:15: error: function might be candidate for attribute ‘noreturn’ [-Werror=suggest-attribute=noreturn] 129 | FMT_FUNC void report_error(const char* message) { | ^~~~~~~~~~~~ cc1plus: all warnings being treated as errors Note that, with `FMT_EXCEPTIONS` defined to 0: ‣ report_error(const char *) uses FMT_THROW() which expands to calling assert_fail(). ‣ assert_fail() calls std::terminate() which has the `[[noreturn]]` attribute since C++11 [1]. Therefore, with `FMT_EXCEPTIONS` defined to 0, both assert_fail() and report_error() need to have the `[[noreturn]]` attribute too (if available). In other words, `FMT_NORETURN` doesn't depend on `FMT_EXCEPTIONS`. Also adding `FMT_NORETURN` to two on_error() functions which call report_error(const char *). Other report_error() overloads eventually return, therefore they don't need `FMT_NORETURN`. [1]: https://en.cppreference.com/w/cpp/error/terminate Signed-off-by: Philippe Proulx <[email protected]>
vitaut
approved these changes
Apr 4, 2024
Merged, thanks. |
happymonkey1
pushed a commit
to happymonkey1/fmt
that referenced
this pull request
Apr 7, 2024
When building `format.cc` as such with GCC 13.2.1: $ g++ -c format.cc -DFMT_EXCEPTIONS=0 -Wmissing-noreturn -Werror I get: In file included from format.cc:8: fmt/format-inl.h: In function ‘void fmt::v10::detail::assert_fail(const char*, int, const char*)’: fmt/format-inl.h:30:15: error: function might be candidate for attribute ‘noreturn’ [-Werror=suggest-attribute=noreturn] 30 | FMT_FUNC void assert_fail(const char* file, int line, const char* message) { | ^~~~~~~~~~~ fmt/format-inl.h: In function ‘void fmt::v10::report_error(const char*)’: fmt/format-inl.h:129:15: error: function might be candidate for attribute ‘noreturn’ [-Werror=suggest-attribute=noreturn] 129 | FMT_FUNC void report_error(const char* message) { | ^~~~~~~~~~~~ cc1plus: all warnings being treated as errors Note that, with `FMT_EXCEPTIONS` defined to 0: ‣ report_error(const char *) uses FMT_THROW() which expands to calling assert_fail(). ‣ assert_fail() calls std::terminate() which has the `[[noreturn]]` attribute since C++11 [1]. Therefore, with `FMT_EXCEPTIONS` defined to 0, both assert_fail() and report_error() need to have the `[[noreturn]]` attribute too (if available). In other words, `FMT_NORETURN` doesn't depend on `FMT_EXCEPTIONS`. Also adding `FMT_NORETURN` to two on_error() functions which call report_error(const char *). Other report_error() overloads eventually return, therefore they don't need `FMT_NORETURN`. [1]: https://en.cppreference.com/w/cpp/error/terminate Signed-off-by: Philippe Proulx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building
format.cc
as such with GCC 13.2.1:I get:
Note that, with
FMT_EXCEPTIONS
defined to 0:report_error(const char *)
usesFMT_THROW()
which expands to callingassert_fail()
.assert_fail()
callsstd::terminate()
which has the[[noreturn]]
attribute since C++11.Therefore, with
FMT_EXCEPTIONS
defined to 0, bothassert_fail()
andreport_error()
need to have the[[noreturn]]
attribute too (if available). In other words,FMT_NORETURN
doesn't depend onFMT_EXCEPTIONS
.Also adding
FMT_NORETURN
to twoon_error()
functions which callreport_error(const char *)
.Other
report_error()
overloads eventually return, therefore they don't needFMT_NORETURN
.