Fix warning C4702 emitted from format.h (MSVC) #3866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler: MSVC, Windows x64, Visual Studio 17.9.1
C++ standard: Any (recreatable with anything from c++14 to c++latest)
Fmtlib version: Master branch
Warning level: /W4 or higher
Hi. This is a new warning, not emitted when using the 10.2.1-release, but recreatable from the master branch.
It can easily be recreated by the following lines of code:
It seems that the default-label in the switch-case prevents execution from reaching the bottom of the function. MSVC therefore emits a warning. I haven't tested this on other platforms