Fix warning C4365 emitted from printf.h #3865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler: MSVC, Windows x64, Visual Studio 17.9.1
C++ standard: /std::c++latest
Fmtlib version: 10.2.1
Hi. Thanks for a fantastic library.
While we've generally gotten a few warnings from fmtlib during the last few years, they have decreased over time. On the 10.2.1 release, with our current setup, we only got a single one, a C4365. There might be others, that aren't caught by us, since we disable a few warnings. Our warning level is /W4.
I have not yet been able to create a minimal reproduction case. The following code will compile in a freshly created Visual Studio project, but not in ours:
But the fix for this issue, worked for us. If required I can work more on finding a minimal reproduction case.