Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning C4365 emitted from printf.h #3865

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

Baardi
Copy link
Contributor

@Baardi Baardi commented Feb 23, 2024

Compiler: MSVC, Windows x64, Visual Studio 17.9.1
C++ standard: /std::c++latest
Fmtlib version: 10.2.1

Hi. Thanks for a fantastic library.

While we've generally gotten a few warnings from fmtlib during the last few years, they have decreased over time. On the 10.2.1 release, with our current setup, we only got a single one, a C4365. There might be others, that aren't caught by us, since we disable a few warnings. Our warning level is /W4.

Skjermbilde 2024-02-23 234117

I have not yet been able to create a minimal reproduction case. The following code will compile in a freshly created Visual Studio project, but not in ours:

#define FMT_HEADER_ONLY
#include "fmt/printf.h"

void test
{
   fmt::printf("%s", "test");
}

But the fix for this issue, worked for us. If required I can work more on finding a minimal reproduction case.

@vitaut vitaut merged commit ddf0b7d into fmtlib:master Feb 24, 2024
41 checks passed
@vitaut
Copy link
Contributor

vitaut commented Feb 24, 2024

thanks

happymonkey1 pushed a commit to happymonkey1/fmt that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants