Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake build #3741

Closed
wants to merge 1 commit into from
Closed

Fix CMake build #3741

wants to merge 1 commit into from

Conversation

H1X4Dev
Copy link
Contributor

@H1X4Dev H1X4Dev commented Dec 8, 2023

After the change in 81629e4, seems like it broke CMake builds when using CPM, this pull request fixes that.

1> [CMake] CMake Error at out/build/x64-Debug/_deps/fmt-src/CMakeLists.txt:55 (target_sources):
1> [CMake]   Cannot find source file:
1> [CMake] 
1> [CMake]     README.rst
1> [CMake] Call Stack (most recent call first):
1> [CMake]   out/build/x64-Debug/_deps/fmt-src/CMakeLists.txt:285 (add_module_library)
1> [CMake] CMake Error at out/build/x64-Debug/_deps/fmt-src/CMakeLists.txt:50 (add_library):
1> [CMake]   No SOURCES given to target: fmt
1> [CMake] Call Stack (most recent call first):
1> [CMake]   out/build/x64-Debug/_deps/fmt-src/CMakeLists.txt:285 (add_module_library)
1> [CMake] CMake Generate step failed.  Build files cannot be regenerated correctly.

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you also update line 451?

@dde-cls
Copy link

dde-cls commented Dec 8, 2023

I opened this related issue: #3742

I suppose it just boils down to rectify the reference in CMakeLists.txt, line 286.

@vitaut
Copy link
Contributor

vitaut commented Dec 8, 2023

Could you also update line 451?

Nevermind, I applied the change locally. Merged in 4497a2d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants