allow format_as() to format reference #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Dec 9, 2023
include/fmt/core.h
Outdated
| @@ -1332,7 +1332,7 @@ using ulong_type = conditional_t<long_short, unsigned, unsigned long long>; | |||
| template <typename T> struct format_as_result { | |||
| template <typename U, | |||
| FMT_ENABLE_IF(std::is_enum<U>::value || std::is_class<U>::value)> | |||
| static auto map(U*) -> decltype(format_as(std::declval<U>())); | |||
| static auto map(U*) -> typename std::decay<decltype(format_as(std::declval<U>()))>::type; | |||
There was a problem hiding this comment.
I think this should be remove_cvref_t and not decay.
There was a problem hiding this comment.
yes. it's a better fit in this case.
test/format-test.cc
Outdated
| struct struct_as_const_reference { | ||
| const std::string name = "foo"; | ||
| }; | ||
| auto format_as(const struct_as_const_reference& s) -> const std::string& { return s.name; } |
|
v2:
|
before this change, format_as() is unable to format a type which has `auto format_as() -> const another_type&`, and `another_type` is formattable. because `format_as_result` maps the result type as it is, and the compiler refuses to compile `static_cast<T*>(nullptr)`, where T is a reference type. but it would be handy if we could use `format_as()` to format types which, for instance, owns / inherit from a formattable type, and delegate the formatter to these variables instead without creating a copy of them. in this change: * instruct `format_as_result` to map the result type to the decayed type, so that `type` can be the decayed type of result type, and this also enables `type` to be formattable, as long as the decayed type is formattable. * corresponding test is added to format-test.cc Signed-off-by: Kefu Chai <[email protected]>
vitaut
approved these changes
Dec 10, 2023
|
Merged, thanks! |
happymonkey1
pushed a commit
to happymonkey1/fmt
that referenced
this pull request
Apr 7, 2024
before this change, format_as() is unable to format a type which has `auto format_as() -> const another_type&`, and `another_type` is formattable. because `format_as_result` maps the result type as it is, and the compiler refuses to compile `static_cast<T*>(nullptr)`, where T is a reference type. but it would be handy if we could use `format_as()` to format types which, for instance, owns / inherit from a formattable type, and delegate the formatter to these variables instead without creating a copy of them. in this change: * instruct `format_as_result` to map the result type to the decayed type, so that `type` can be the decayed type of result type, and this also enables `type` to be formattable, as long as the decayed type is formattable. * corresponding test is added to format-test.cc Signed-off-by: Kefu Chai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, format_as() is unable to format a type which has
auto format_as() -> const another_type&, andanother_typeis formattable. becauseformat_as_resultmaps the result type as it is, and the compiler refuses to compilestatic_cast<T*>(nullptr), where T is a reference type. but it would be handy if we could useformat_as()to format types which, for instance, owns / inherit from a formattable type, and delegate the formatter to these variables instead without creating a copy of them.in this change:
format_as_resultto map the result type to the decayed type, so thattypecan be the decayed type of result type, and this also enablestypeto be formattable, as long as the decayed type is formattable.