Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error C2668 on Windows with option /std:c++latest #3680

Merged
merged 2 commits into from
Oct 16, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Namespace-qualify to avoid ambiguity with std::format_to for format-t…
…est.cc

When build fmt with MSVC under option /std:c++latest, it failed due to `error 2668: 'std::format_to': ambiguous call to overloaded function`, so add namespace to qualify the call to format_to to avoid this issue.
Zhaojun-Liu authored Oct 13, 2023
commit 3b02292469969135b597864a901003dbdc739d12
3 changes: 2 additions & 1 deletion test/format-test.cc
Original file line number Diff line number Diff line change
@@ -1788,7 +1788,8 @@ FMT_BEGIN_NAMESPACE
template <> struct formatter<point> : nested_formatter<double> {
auto format(point p, format_context& ctx) const -> decltype(ctx.out()) {
return write_padded(ctx, [this, p](auto out) -> decltype(out) {
return format_to(out, "({}, {})", nested(p.x), nested(p.y));
// Namespace-qualify to avoid ambiguity with std::format_to
Zhaojun-Liu marked this conversation as resolved.
Show resolved Hide resolved
return fmt::format_to(out, "({}, {})", nested(p.x), nested(p.y));
});
}
};