Added synchronization with the main storage device before direct recording #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Oct 14, 2023
Roman-Koshelev
force-pushed
the
master
branch
from
c999ce9 to
7c19f40
Compare
|
Done. |
vitaut
reviewed
Oct 21, 2023
include/fmt/ostream.h
Outdated
| #endif | ||
| return false; | ||
| if (!c_file) return false; | ||
| os.flush(); |
There was a problem hiding this comment.
We should only flush the buffer when writing to a console. I suggest moving the ostream change to a separate PR and addressing this issue. The rest LGTM.
Roman-Koshelev
force-pushed
the
master
branch
from
7c19f40 to
bb7490e
Compare
Roman-Koshelev
force-pushed
the
master
branch
from
bb7490e to
4fe961f
Compare
vitaut
approved these changes
Oct 23, 2023
|
Merged without the ostream part in 3b7f58a. Thanks. |
dimztimz
reviewed
Oct 25, 2023
| if (!_isatty(fd)) return false; | ||
| std::fflush(f); |
There was a problem hiding this comment.
Adding fflush here is not correct. This function write_console() is called either from the C stream print() or the C++ iostream print(). In the latter case, fflush should not be called at all, instead the ostream flush should be invoked.
There was a problem hiding this comment.
This flush is indeed redundant for iostream but in the future please report issues like these once to avoid too much notification noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reset of caching stream buffers before direct writing to the descriptor