fix redundant redeclaration of ‘constexpr’ static data member #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phprus
reviewed
Sep 8, 2023
Comment on lines
-339
to
-340
| template <typename CodeUnit> | ||
| constexpr const size_t codecvt_result<CodeUnit>::max_size; |
There was a problem hiding this comment.
Suggest:
#if FMT_CPLUSPLUS < 201703L
template <typename CodeUnit>
constexpr const size_t codecvt_result<CodeUnit>::max_size;
#endif
There was a problem hiding this comment.
I'd prefer avoiding conditional compilation if possible.
There was a problem hiding this comment.
@vitaut
This is C++ :(
https://en.cppreference.com/w/cpp/language/static#Static_data_members
If a const non-inline (since C++17) static data member or a constexpr static data member (since C++11)(until C++17) is odr-used, a definition at namespace scope is still required, but it cannot have an initializer.
There was a problem hiding this comment.
But it doesn't need to be ODR-used so it should be fine.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.