Fix for FMT_MODULE not compiling on GCC #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Aug 23, 2023
- Remove umul128 friend function from uint128_fallback class using non-const member access functions instead.
|
I hope this is what you had in mind. |
vitaut
requested changes
Aug 24, 2023
include/fmt/format.h
Outdated
Comment on lines
1492
to
1494
| auto result = uint128_fallback(); | ||
| result.lo_ = _umul128(x, y, &result.hi_); | ||
| result.low() = _umul128(x, y, &result.high()); | ||
| return result; |
There was a problem hiding this comment.
Let's change this to something like:
auto hi = uint64_t();
auto lo = _umul128(x, y, &hi);
return {hi, lo};and remove the new accessors.
- Removal of direct access to members of uint128_fallback and instead create the values at the callsite and pass them via the constructor of uint128_fallback on the return statement.
vitaut
approved these changes
Aug 25, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the friend function declaration has made compilation with FMT_MODULE succeed on GCC on linux. Also Tested with clang on linux.
However I have noted some failed checks with windows.
Perhaps a macro could now fix #3587