Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues #3598 #3599

Merged
merged 3 commits into from
Aug 19, 2023
Merged

fix issues #3598 #3599

merged 3 commits into from
Aug 19, 2023

Conversation

YuHuanTin
Copy link
Contributor

fix issues #3598

@vitaut
Copy link
Contributor

vitaut commented Aug 19, 2023

Thanks for the PR but � is a valid Unicode character and I don't think we should replace it.

@vitaut vitaut closed this Aug 19, 2023
@vitaut vitaut mentioned this pull request Aug 19, 2023
Closed
@vitaut vitaut reopened this Aug 19, 2023
@vitaut vitaut merged commit bd868f3 into fmtlib:master Aug 19, 2023
@vitaut
Copy link
Contributor

vitaut commented Aug 19, 2023

OK, let's merge it since it's a simple change that doesn't affect the common case of UTF-8.

@AlexGuteniev
Copy link
Contributor

44rmwd

@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 28, 2023
Merged
@toge toge mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuHuanTin @vitaut @AlexGuteniev