to_string supports types with format_as #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2023
Closed
vitaut
reviewed
Aug 13, 2023
include/fmt/format.h
Outdated
Comment on lines
4300
to
4302
| auto buffer = memory_buffer(); | ||
| detail::write<char>(appender(buffer), format_as(value)); | ||
| return {buffer.data(), buffer.size()}; |
There was a problem hiding this comment.
I suggest changing this to to_string(format_as(value)) which is simpler and more efficient for types that map to integers.
Signed-off-by: Vladislav Shchapov <[email protected]>
phprus
force-pushed
the
to_string_format_as
branch
from
5e5a31f to
06c4c7f
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue: #3545
Previous PR: #3555