Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ambiguous formatter lookup for flat_set #3561

Merged

Conversation

5chmidti
Copy link
Contributor

Fixes #3556

The underlying issue was that the flat_set of boost (and in theory of std), could match is_set and is_container_adaptor_like at the same time. This resulted in an ambiguous lookup of the formatters for ranges and range adaptors.

I added the change that @vitaut suggested in the issue and tested the change with a minimal reproducer of the original issue (a range that matches is_set and is_container_adaptor_like).

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Overall looks good but please fix build failures.

@vitaut vitaut merged commit 8a4bec5 into fmtlib:master Jul 31, 2023
@vitaut
Copy link
Contributor

vitaut commented Jul 31, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous partial specialization when formatting boost flat_set since fmt v10.0.0
2 participants