fix ambiguous formatter lookup for flat_set #3561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3556
The underlying issue was that the
flat_set
of boost (and in theory of std), could matchis_set
andis_container_adaptor_like
at the same time. This resulted in an ambiguous lookup of the formatters for ranges and range adaptors.I added the change that @vitaut suggested in the issue and tested the change with a minimal reproducer of the original issue (a range that matches
is_set
andis_container_adaptor_like
).