CMake: Do not fail on unknown compiler features #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
May 21, 2023
CMakeLists.txt
Outdated
Comment on lines
300
to
304
| if(cxx_std_11 IN_LIST CMAKE_CXX_COMPILE_FEATURES) | ||
| target_compile_features(fmt PUBLIC cxx_std_11) | ||
| else() | ||
| message(WARNING "Feature cxx_std_11 is unknown for the CXX compiler") | ||
| endif() |
There was a problem hiding this comment.
nit: we use spaces after control flow CMake commands like if/else/endif, e.g.
if (...)
If CMake does not know much about a compiler, `target_compile_features` will fail. Issue a warning instead.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CMake does not know much about a compiler,
target_compile_featureswill fail. Issue a warning instead.