Fix time_point formatting for durations with certain ratios #3430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3261 unfortunately broke formatting for
std::chrono::time_point
s with durations with certain ratios, sincestd::chrono::seconds
is not implicitly convertible to these durations.This PR fixes this by explicitly
duration_cast
-ing back to thetime_point
'sDuration
.Repro: The following worked in 9.1.0, but doesn't compile in 10.0.0: