Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

names declared to be exported at the point of introduction into a nam… #3392

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

DanielaE
Copy link
Contributor

…espace must not be (re-)declared as exported later in the TU, e.g. when they are redeclared, defined, or specialized. [module.export]/6

names declared to be exported at the point of introduction into a namespace *must not* be (re-)declared as exported later in the TU, e.g. when they are redeclared, defined, or specialized. [module.export]/6

Drive-by fix found during module testing: add a missing `detail::` name qualification
@DanielaE DanielaE force-pushed the feature/don't-export-twice branch from aa5b268 to 78e0071 Compare April 19, 2023 06:05
@vitaut vitaut merged commit c039389 into fmtlib:master Apr 22, 2023
@vitaut
Copy link
Contributor

vitaut commented Apr 22, 2023

Thank you!

@DanielaE DanielaE deleted the feature/don't-export-twice branch April 23, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants