Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adjust chrono_format_spec documentation to match library behavior #3239

Closed
wants to merge 1 commit into from
Closed

Conversation

jengelh
Copy link

@jengelh jengelh commented Dec 22, 2022

References: #3237

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We shouldn't remove the part of the grammar because it is valid for durations. I suggest clarifying that time points only support chrono_specs at the moment in a sentence below the grammar.

@jengelh
Copy link
Author

jengelh commented Dec 23, 2022

Since durations don't do conversion ({:%d}), I've changed the syntax for durations to not include conversion_spec anymore.

@jengelh jengelh requested a review from vitaut December 23, 2022 15:50
@vitaut
Copy link
Contributor

vitaut commented Dec 23, 2022

Durations do support conversion specifiers except calendaric so please revert that change. We already explain the calendaric part in the docs.

@vitaut
Copy link
Contributor

vitaut commented Jan 2, 2023

@jengelh do you still plan to update this PR per my earlier comment?

@jengelh
Copy link
Author

jengelh commented Jan 2, 2023

I don't know how to dismiss this "Changes requested" box - GH does not notice the new change and does not show a "Done" button or something that I could have sworn existed elsewhere. whatever

vitaut
vitaut previously approved these changes Jan 3, 2023

.. productionlist:: sf
chrono_format_spec: [[`fill`]`align`][`width`]["." `precision`][`chrono_specs`]
chrono_specs: [`chrono_specs`] `literal_char`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect because durations support conversion specifiers. Let's correct it by removing this line which will also fix duplicate definition of chrono_specs.

@vitaut vitaut self-requested a review January 3, 2023 20:11
@vitaut vitaut dismissed their stale review January 3, 2023 20:12

still needs changes

@vitaut
Copy link
Contributor

vitaut commented Jan 4, 2023

This is no longer needed because time points are getting missing format specifier support in #3260 but thanks anyway.

@vitaut vitaut closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants