-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: adjust chrono_format_spec documentation to match library behavior #3239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. We shouldn't remove the part of the grammar because it is valid for durations. I suggest clarifying that time points only support chrono_specs at the moment in a sentence below the grammar.
Since durations don't do conversion ( |
Durations do support conversion specifiers except calendaric so please revert that change. We already explain the calendaric part in the docs. |
@jengelh do you still plan to update this PR per my earlier comment? |
I don't know how to dismiss this "Changes requested" box - GH does not notice the new change and does not show a "Done" button or something that I could have sworn existed elsewhere. whatever |
|
||
.. productionlist:: sf | ||
chrono_format_spec: [[`fill`]`align`][`width`]["." `precision`][`chrono_specs`] | ||
chrono_specs: [`chrono_specs`] `literal_char` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect because durations support conversion specifiers. Let's correct it by removing this line which will also fix duplicate definition of chrono_specs
.
This is no longer needed because time points are getting missing format specifier support in #3260 but thanks anyway. |
References: #3237