Replacing snprintf-based hex float formatter with internal implementation #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phprus
commented
Nov 13, 2022
phprus
commented
- Replacing snprintf-based hex float formatter with internal implementation.
- Add missing env CTEST_OUTPUT_ON_FAILURE.
- Enable C++17 tests on macOS for simplify hex float tests.
|
Benchmark: MacbookPro M1 Max:
|
phprus
force-pushed
the
hexfloat-1
branch
3 times, most recently
from
7bdac5c to
8dbd9fd
Compare
vitaut
requested changes
Nov 16, 2022
Merged
|
@vitaut, Rebased. |
Signed-off-by: Vladislav Shchapov <[email protected]>
Signed-off-by: Vladislav Shchapov <[email protected]>
|
Rebased onto master |
vitaut
reviewed
Nov 24, 2022
|
|
||
| constexpr auto leading_shift = ((num_xdigits - 1) * 4); | ||
| const auto leading_mask = carrier_uint(0xF) << leading_shift; | ||
| const auto leading_v = |
There was a problem hiding this comment.
"value".
But, probably, it would be more correct name: "leading_[hex]digit" or "most_significant_[hex]digit".
Now I think leading_* are not good names.
Make a PR with renaming? If yes, which option should I choose?
There was a problem hiding this comment.
A PR sounds good. I think leading_hexdigit or leading_xdigit (for consistency with num_xdigits) is fine. most_significant_* might be more precise but longer and I think leading is clear enough.
vitaut
approved these changes
Nov 24, 2022
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.