Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move formatter<std::error_code> from fmt/os.h to fmt/std.h #3125

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

phprus
Copy link
Contributor

@phprus phprus commented Oct 1, 2022

Issue: #3123

test/std-test.cc Outdated Show resolved Hide resolved
@phprus phprus force-pushed the format-error_code-2 branch from 0d55cef to 720f562 Compare October 1, 2022 22:03
@vitaut vitaut merged commit 662adf4 into fmtlib:master Oct 2, 2022
@vitaut
Copy link
Contributor

vitaut commented Oct 2, 2022

Thank you!

@tupaschoal
Copy link
Contributor

Should this PR also have touched documentation for std.h? It currently does not say that it provides formatting for error_code, just:

fmt/std.h provides formatters for:

[std::filesystem::path](https://en.cppreference.com/w/cpp/filesystem/path)

[std::thread::id](https://en.cppreference.com/w/cpp/thread/thread/id)

[std::monostate](https://en.cppreference.com/w/cpp/utility/variant/monostate)

[std::variant](https://en.cppreference.com/w/cpp/utility/variant/variant)

[std::optional](https://en.cppreference.com/w/cpp/utility/optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants