Add support Microsoft Visual Studio 2022. #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dani-Hub
reviewed
Jul 3, 2022
| @@ -294,7 +294,14 @@ TEST(compile_test, compile_format_string_literal) { | |||
| } | |||
| #endif | |||
|
|
|||
| #if FMT_CPLUSPLUS >= 202002L || \ | |||
| // MSVS 2019 19.29.30145.0 - Support C++20 and OK. | |||
| // MSVS 2022 19.32.31332.0 - compile-test.cc(362,3): fatal error C1001: Internal | |||
There was a problem hiding this comment.
@phprus Have you checked whether a corresponding Visual Studio 2022 issue exists for this problem?
There was a problem hiding this comment.
Maybe it's https://developercommunity.visualstudio.com/t/internal-compiler-error-c1001-in-compiler-file-da0/1661750 but I'm not sure.
Signed-off-by: Vladislav Shchapov <[email protected]>
Signed-off-by: Vladislav Shchapov <[email protected]>
D:\a\fmt\fmt\test\compile-test.cc(362,3): fatal error C1001: Internal compiler error. [D:\a\fmt\build\test\compile-test.vcxproj] (compiler file 'D:\a\_work\1\s\src\vctools\Compiler\CxxFE\sl\p1\c\constexpr\constexpr.cpp', line 8635) Signed-off-by: Vladislav Shchapov <[email protected]>
|
Rebased. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2958 (On MSVC 2022 with
/std:c++20:FMT_CPLUSPLUS == 202002L).New CI tasks, Replace
__cpluspluswithFMT_CPLUSPLUS(for MSVC) and Add workaround for MSVC 2022 ICE.Additional Information:
Internal compiler error message for commit "Workaround to Microsoft Visual Studio 2022 Internal compiler error.":