Added a FMT_STRING wrapper for system_error() call. #2929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, using
fmt
withFMT_ENFORCE_COMPILE_STRING
in MSVC 2019 results in failed compilation infmt
itself:(I'm using
fmt
as a git submodule in another project, using CMake for build and addingtarget_compile_definitions(fmt-header-only INTERFACE FMT_ENFORCE_COMPILE_STRING=1)
to my CMakeLists.txtI agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.